Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split package module further to avoid recursive imports #715

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Split package module further to avoid recursive imports #715

wants to merge 1 commit into from

Conversation

dirkmueller
Copy link
Member

This completes the previous modularization effort by splitting into globals, dataclasses and utils.

@dirkmueller dirkmueller force-pushed the dataclasses branch 3 times, most recently from 333f2c7 to e50343c Compare October 17, 2023 12:47
dcermak pushed a commit that referenced this pull request Oct 17, 2023
@dirkmueller
Test build for #715
4d7f1af
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Created a staging project on OBS for Basalt: home:defolos:BCI:Staging:Basalt:Basalt-ugrFI
Changes pushed to branch Basalt-ugrFI as commit 4d7f1af726da6e8a2e6684fecbf7af1edc3656ca
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

dcermak
dcermak requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the documentation fails:

/__w/BCI-dockerfile-generator/BCI-dockerfile-generator/source/adding_containers.rst:6:py:class reference target not found: bci_build.package.LanguageStackContainer

src/bci_build/package/appcontainers.py Outdated Show resolved Hide resolved
src/bci_build/package/globals.py Outdated Show resolved Hide resolved
src/bci_build/package/globals.py Outdated Show resolved Hide resolved
@dirkmueller
Split package module further to avoid recursive imports
6f8b732 
This completes the previous modularization effort by splitting into
constants, bciclasses and utils.
@dirkmueller
Copy link
Member Author

Building the documentation fails:

I've seen that. I do not yet know why that is however.

dcermak pushed a commit that referenced this pull request Oct 19, 2023
@dirkmueller
Test build for #715
48d0d5d
dcermak pushed a commit that referenced this pull request Oct 19, 2023
@dirkmueller
Test build for #715
ee6ba1d
dcermak pushed a commit that referenced this pull request Oct 19, 2023
@dirkmueller
Test build for #715
df1206b
dcermak pushed a commit that referenced this pull request Oct 19, 2023
@dirkmueller
Test build for #715
85ed1f6
@github-actions
Copy link

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:sle15-sp6-WjJUe
Changes pushed to branch sle15-sp6-WjJUe as commit 48d0d5d09b54fce69f02a2bb09726e1168e86356

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Created a staging project on OBS for Basalt: home:defolos:BCI:Staging:Basalt:Basalt-admCu
Changes pushed to branch Basalt-admCu as commit df1206b7ce41cbe5a7e74bf176d00093edade7a7
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Basalt:Basalt-admCu for x86_64: current state: published
Build results:

package name status build log
base-image ✅ succeeded live log

Repository images in home:defolos:BCI:Staging:Basalt:Basalt-admCu for aarch64: current state: published
Build results:

package name status build log
base-image ✅ succeeded live log

Repository images in home:defolos:BCI:Staging:Basalt:Basalt-admCu for s390x: current state: published
Build results:

package name status build log
base-image ✅ succeeded live log

Repository images in home:defolos:BCI:Staging:Basalt:Basalt-admCu for ppc64le: current state: published
Build results:

package name status build log
base-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Basalt:Basalt-admCu for x86_64: current state: published
Build results:

package name status build log
base-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Basalt:Basalt-admCu for aarch64: current state: published
Build results:

package name status build log
base-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Basalt:Basalt-admCu for s390x: current state: published
Build results:

package name status build log
base-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Basalt:Basalt-admCu for ppc64le: current state: published
Build results:

package name status build log
base-image ⛔ excluded live log

Build succeeded ✅

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FLuop
Changes pushed to branch Tumbleweed-FLuop as commit ee6ba1da4208d95df2cc0793baa87e959b96859e
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FLuop for x86_64: current state: published
Build results:

package name status build log
php-apache8-image ⛔ excluded live log
php-fpm8-image ⛔ excluded live log
php8-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FLuop for aarch64: current state: published
Build results:

package name status build log
php-apache8-image ⛔ excluded live log
php-fpm8-image ⛔ excluded live log
php8-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FLuop for x86_64: current state: published
Build results:

package name status build log
php-apache8-image ✅ succeeded live log
php-fpm8-image ✅ succeeded live log
php8-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-FLuop for aarch64: current state: published
Build results:

package name status build log
php-apache8-image ✅ succeeded live log
php-fpm8-image ✅ succeeded live log
php8-image ✅ succeeded live log

Build succeeded ✅

@github-actions
Copy link

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:sle15-sp5-LQxkF
Changes pushed to branch sle15-sp5-LQxkF as commit 85ed1f68ce28c59a62e3cb5fa927f0b87fd19938

@dirkmueller dirkmueller marked this pull request as draft October 19, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcermak dcermak dcermak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmueller @dcermak